Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Referential context: with_context and update_context #3279

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Referential context: with_context and update_context #3279

merged 3 commits into from
Dec 16, 2024

Conversation

zakstucke
Copy link
Contributor

No description provided.

gbj
gbj reviewed Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@gbj gbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! And thanks for fixing the double-locking bug in take_context that someone mentioned to me in passing three months ago but never made a PR to fix. Two notes on docs and this should be good to go.

@zakstucke
Copy link
Contributor Author

Updated!

@gbj gbj merged commit bc9c3ad into leptos-rs:main Dec 16, 2024
74 checks passed
@gbj
Copy link
Collaborator

gbj commented Dec 16, 2024

Thanks very much!

@andrewdavidmackenzie andrewdavidmackenzie mentioned this pull request Dec 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbj gbj gbj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zakstucke @gbj